cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-windows pull request #213: CB-12163 Make resource-file copy files ag...
Date Wed, 14 Dec 2016 08:54:05 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: template/cordova/lib/JsprojManager.js ---
    @@ -121,7 +121,12 @@ jsprojManager.prototype = {
             copyToOutputDirectory.text = 'Always';
    -        var item = createItemGroupElement('ItemGroup/Content', sourcePath, targetConditions,
    +        var item;
    --- End diff --
    IMO it'd be better to calculate path for `content` element outside this method (in `'resource-file'.install`)
- this way you will avoid checking the same condition (`if (targetConditions.reference) ...`)
twice and won't need to modify this method at all.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message