cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...
Date Tue, 13 Dec 2016 22:49:16 GMT
Github user filmaj commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92285052
  
    --- Diff: appium-tests/common/common.spec.js ---
    @@ -242,7 +248,6 @@ describe('Contacts Android', function () {
     
         describe('Picking contacts', function () {
             afterEach(function (done) {
    -            checkSession(done);
    --- End diff --
    
    I still left the removal of this check, @alsorokin, as I don't think it makes sense to
put in the `afterEach`. With the spec itself invoking `checkSession`, if the appium session
failed to start, it would get caught in the spec. In fact, we could probably get away with
checking the session only immediately after the initial `should connect to an appium endpoint
properly` spec. Any further checks beyond that would not behave any differently.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message