cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...
Date Tue, 13 Dec 2016 15:05:35 GMT
Github user filmaj commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r92186809
  
    --- Diff: appium-tests/common/common.spec.js ---
    @@ -228,11 +228,18 @@ describe('Contacts Android', function () {
         function checkSession(done) {
             if (failedToStart) {
                 fail('Failed to start a session');
    -            done();
             }
    +        done();
    --- End diff --
    
    In the failing case, the call to `fail` should blow the spec up, no? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message