cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-paramedic pull request #18: Appium updates for Paramedic
Date Tue, 13 Dec 2016 07:58:59 GMT
Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/18#discussion_r92112118
  
    --- Diff: lib/paramedic.js ---
    @@ -271,9 +271,13 @@ ParamedicRunner.prototype.runLocalTests = function () {
         })
         .then(function(command) {
             self.setPermissions();
    -        logger.normal('cordova-paramedic: running command ' + command);
     
    -        return execPromise(command);
    +        if (!self.config.runMainTests()) {
    --- End diff --
    
    This change would break local Android Appium run, I believe. See the comment on line 283.
    We need to boot up an Android emulator for Appium to run tests on and skipping this command
would skip starting the emulator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message