cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <>
Subject [GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...
Date Mon, 12 Dec 2016 15:38:44 GMT
Github user alsorokin commented on a diff in the pull request:
    --- Diff: appium-tests/common/common.spec.js ---
    @@ -242,7 +248,6 @@ describe('Contacts Android', function () {
         describe('Picking contacts', function () {
             afterEach(function (done) {
    -            checkSession(done);
    --- End diff --
    As far as I remember, this check is to quickly fail without extra requests to the driver.
Because when the session is failed to start it could just get unresponsive and we would just
sit there and wait for every test to time out.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message