cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-medic pull request #106: Appium updates
Date Mon, 12 Dec 2016 08:01:02 GMT
Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/106#discussion_r91896443
  
    --- Diff: medic/medic-appium.js ---
    @@ -355,9 +358,8 @@ function isFailFastError(error) {
     function killProcess(procObj, killSignal, callback) {
         if (procObj.alive) {
             procObj.alive = false;
    -        setTimeout(function () {
    -            kill(procObj.process.pid, killSignal, callback);
    -        }, 1000);
    --- End diff --
    
    As far as I remember, these process-killing timeouts were needed to give the treekill
module some time to actually kill the process. On mac it may be fine, but on Windows the Appium
process is left hanging in the memory and occupying the port.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message