cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request #143: Jasmine use of `afterAll` and lab...
Date Mon, 12 Dec 2016 05:01:23 GMT
Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/143#discussion_r91883510
  
    --- Diff: appium-tests/common/common.spec.js ---
    @@ -232,7 +232,13 @@ describe('Contacts Android', function () {
             }
         }
     
    -    it('contacts.ui.util configuring driver and starting a session', function (done)
{
    +    afterAll(function (done) {
    +        driver
    --- End diff --
    
    Wouldn't hurt to call `checkSession()` here too, because I believe we don't need to call
`driver.quit()` if session is not started, and if the driver is undefined, it could lead to
the error message like "undefined is not a function".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message