cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
Date Mon, 05 Dec 2016 10:13:43 GMT
Github user jcesarmobile commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/197#discussion_r90834795
  
    --- Diff: README.md ---
    @@ -131,6 +132,7 @@ instance, or the system browser.
         - __presentationstyle__:  Set to `pagesheet`, `formsheet` or `fullscreen` to set
the [presentation style](http://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalPresentationStyle)
(defaults to `fullscreen`).
         - __transitionstyle__: Set to `fliphorizontal`, `crossdissolve` or `coververtical`
to set the [transition style](http://developer.apple.com/library/ios/#documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalTransitionStyle)
(defaults to `coververtical`).
         - __toolbarposition__: Set to `top` or `bottom` (default is `bottom`). Causes the
toolbar to be at the top or bottom of the window.
    +    - __hidenotclose__: set to 'yes' to make the done/close button hide the browser window
rather than closing the browser (defaults to 'no')
    --- End diff --
    
    yeah, it's for both, but the preference is documented for both too, so in the iOS section
it should say "done" and in the Android section it should say "close" instead of saying "done/close"
on both


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message