Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: cjpearson <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-23-cordova-plugin-wkwebview-engine@git.apache.org>
In-Reply-To: <git-pr-23-cordova-plugin-wkwebview-engine@git.apache.org>
Subject: [GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...
Content-Type: text/plain
Message-Id: <20161130123051.A0C93DFCF7@git1-us-west.apache.org>
Date: Wed, 30 Nov 2016 12:30:51 +0000 (UTC)
archived-at: Wed, 30 Nov 2016 12:30:53 -0000

Github user cjpearson commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90223157
  
    --- Diff: src/ios/CDVWKWebViewEngine.m ---
    @@ -123,6 +123,32 @@ - (void)pluginInitialize
                    name:UIApplicationWillEnterForegroundNotification object:nil];
     
         NSLog(@"Using WKWebView");
    +
    +    [self addURLObserver];
    +}
    +
    +- (void)onReset {
    +    [self addURLObserver];
    +}
    +
    +static void * KVOContext = &KVOContext;
    +
    +- (void)addURLObserver {
    +    if(![[NSProcessInfo processInfo] isOperatingSystemAtLeastVersion:(NSOperatingSystemVersion){.majorVersion = 9, .minorVersion = 0, .patchVersion = 0 }]){
    --- End diff --
    
    Yeah I was using the local webserver plugin to support iOS 8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org