Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: vladimir-kotikov <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-212-cordova-windows@git.apache.org>
In-Reply-To: <git-pr-212-cordova-windows@git.apache.org>
Subject: [GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...
Content-Type: text/plain
Message-Id: <20161129121027.1B46EE2F35@git1-us-west.apache.org>
Date: Tue, 29 Nov 2016 12:10:27 +0000 (UTC)
archived-at: Tue, 29 Nov 2016 12:10:29 -0000

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/212#discussion_r89991437
  
    --- Diff: template/cordova/lib/prepare.js ---
    @@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest) {
         manifest.getApplication().setAccessRules(whitelistRules);
     }
     
    -function mapImageResources(images, imagesDir) {
    -    var pathMap = {};
    +// Platform default images
    +var platformImages = [
    --- End diff --
    
    nit: could you please make it uppercase, so i'd be easy to understand in code that we're using some constant value


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org