Return-Path: <dev-return-64806-archive-asf-public=cust-asf.ponee.io@cordova.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id C72C4200BBF
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 14 Nov 2016 09:10:29 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id C5DB3160B06; Mon, 14 Nov 2016 08:10:29 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 1D1F1160B05
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 14 Nov 2016 09:10:28 +0100 (CET)
Received: (qmail 97502 invoked by uid 500); 14 Nov 2016 08:10:27 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 96928 invoked by uid 99); 14 Nov 2016 08:10:27 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Nov 2016 08:10:27 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id D3F8FE01D9; Mon, 14 Nov 2016 08:10:26 +0000 (UTC)
From: vladimir-kotikov <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-207-cordova-windows@git.apache.org>
In-Reply-To: <git-pr-207-cordova-windows@git.apache.org>
Subject: [GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...
Content-Type: text/plain
Message-Id: <20161114081026.D3F8FE01D9@git1-us-west.apache.org>
Date: Mon, 14 Nov 2016 08:10:26 +0000 (UTC)
archived-at: Mon, 14 Nov 2016 08:10:30 -0000

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/207#discussion_r87751494
  
    --- Diff: template/cordova/lib/PluginInfo.js ---
    @@ -0,0 +1,109 @@
    +var semver = require('semver');
    +var CommonPluginInfo = require('cordova-common').PluginInfo;
    +
    +var MANIFESTS = {
    +    'windows': {
    +        '8.1.0': 'package.windows.appxmanifest',
    +        '10.0.0': 'package.windows10.appxmanifest'
    +    },
    +    'phone': {
    +        '8.1.0': 'package.phone.appxmanifest',
    +        '10.0.0': 'package.windows10.appxmanifest'
    +    },
    +    'all': {
    +        '8.1.0': ['package.windows.appxmanifest', 'package.phone.appxmanifest'],
    +        '10.0.0': 'package.windows10.appxmanifest'
    +    }
    +};
    +
    +/*
    +A class for holidng the information currently stored in plugin.xml
    +It's inherited from cordova-common's PluginInfo class
    +In addition it overrides getConfigFiles method to use windows-specific logic
    + */
    +function PluginInfo(dirname) {
    +    CommonPluginInfo.apply(this, arguments);
    +    var parentGetConfigFiles = this.getConfigFiles;
    +    this.getConfigFiles = function(platform) {
    +        var changes = parentGetConfigFiles(platform);
    +        var editChanges = this.getEditConfigs(platform);
    --- End diff --
    
    I don't think that we should do something with `<edit-config>` tags here. You'd probably need to override parent `getEditConfigs` method in a same way as `getConfigFiles` possibly sharing the similar logic between them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org