Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9F6EB200BBB for ; Thu, 10 Nov 2016 23:53:30 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9E26B160B10; Thu, 10 Nov 2016 22:53:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 19D0B160AF7 for ; Thu, 10 Nov 2016 23:53:29 +0100 (CET) Received: (qmail 72503 invoked by uid 500); 10 Nov 2016 22:53:29 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 72481 invoked by uid 99); 10 Nov 2016 22:53:28 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Nov 2016 22:53:28 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CF749E01F4; Thu, 10 Nov 2016 22:53:28 +0000 (UTC) From: shazron To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-ios pull request #273: Cb-12098 (iOS) update supportedinterfaceorien... Content-Type: text/plain Message-Id: <20161110225328.CF749E01F4@git1-us-west.apache.org> Date: Thu, 10 Nov 2016 22:53:28 +0000 (UTC) archived-at: Thu, 10 Nov 2016 22:53:30 -0000 Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/273#discussion_r87504333 --- Diff: bin/templates/project/__PROJECT_NAME__/Classes/MainViewController.m --- @@ -92,7 +92,13 @@ - (UIWebView*) newCordovaViewWithFrame:(CGRect)bounds return[super newCordovaViewWithFrame:bounds]; } -- (NSUInteger)supportedInterfaceOrientations +// CB-12098 +#if __IPHONE_OS_VERSION_MAX_ALLOWED < 90000 +- (NSUInteger)supportedInterfaceOrientations +#else +- (UIInterfaceOrientationMask)supportedInterfaceOrientations +#endif + --- End diff -- remove this empty line --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org