cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kerrishotts <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #280: CB-12155: Create automated tests for launch s...
Date Fri, 18 Nov 2016 21:52:46 GMT
GitHub user kerrishotts opened a pull request:

    https://github.com/apache/cordova-ios/pull/280

    CB-12155: Create automated tests for launch storyboard feature

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    - iOS
    
    ### What does this PR do?
    
    Tests the launch storyboard feature introduced by CB-9762. 
    
    ### What testing has been done on this change?
    
    Tests have been tested with `npm run unit-tests`
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.
        - Note: some tests are marked as [PENDING]; need to pull CB-12084 in before those
can be finished


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kerrishotts/cordova-ios CB-12155

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/280.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #280
    
----
commit 222a76265bf28ac3a393b2c5ee1045a2669864eb
Author: Kerri Shotts <kshotts@apache.org>
Date:   2016-11-18T21:43:40Z

    CB-12155: Let there be storyboard tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message