cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cjpearson <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #277: CB-11243: Fix target-device and deployment-ta...
Date Fri, 11 Nov 2016 15:05:42 GMT
GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-ios/pull/277

    CB-11243: Fix target-device and deployment-target preferences

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    
    Fixes target-device and deployment-target preferences. There are several bugs reporting
this issue. [CB-11243](https://issues.apache.org/jira/browse/CB-11243) [CB-11399](https://issues.apache.org/jira/browse/CB-11399)
[CB-11772](https://issues.apache.org/jira/browse/CB-11772) [CB-11732](https://issues.apache.org/jira/browse/CB-11732)
    
    This change adds `IPHONEOS_DEPLOYMENT_TARGET` and `TARGETED_DEVICE_FAMILY` back to the
project file. This is necessary for the preferences to work until [CB-11468](https://issues.apache.org/jira/browse/CB-11468)
is completed.
    
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-ios CB-11243

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/277.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #277
    
----
commit 73c7bf92b14cf27cc66595bad1325b18e456c3eb
Author: Connor Pearson <cjp822@gmail.com>
Date:   2016-11-11T14:17:19Z

    CB-11243: target-device and deployment-target were being ignored

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message