cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NielsLeenheer <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #276: The platform project directory needs to be re...
Date Thu, 10 Nov 2016 14:30:24 GMT
GitHub user NielsLeenheer opened a pull request:

    https://github.com/apache/cordova-ios/pull/276

    The platform project directory needs to be relative to the project

    Launch screen images were not updated or cleaned in
    `updateLaunchStoryboardImages()` or `cleanLaunchStoryboardImages()`
    because the check for `Images.xcassets` in
    `getLaunchStoryboardImagesDir()` failed.
    
    The reason was that the `platformProjDir` and `projectRoot` were
    joined, while both were relative to the root directory. So the
    resulting directory was non-sensical. This changes makes
    `platformProjDir` relative to `cordovaProject.root`, which matches the
    same check in `updateSplashScreens()` and `updateIcons()`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NielsLeenheer/cordova-ios fix-generating-storyboard-images

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/276.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #276
    
----
commit 2a2e0f7dfb1ef315883ff70dbbb5b6a8f6213596
Author: Niels Leenheer <niels@leenheer.nl>
Date:   2016-11-10T14:27:43Z

    The platform project directory needs to be relative to the project
    
    Launch screen images were not updated or cleaned in
    `updateLaunchStoryboardImages()` or `cleanLaunchStoryboardImages()`
    because the check for `Images.xcassets` in
    `getLaunchStoryboardImagesDir()` failed.
    
    The reason was that the `platformProjDir` and `projectRoot` were
    joined, while both were relative to the root directory. So the
    resulting directory was non-sensical. This changes makes
    `platformProjDir` relative to `cordovaProject.root`, which matches the
    same check in `updateSplashScreens()` and `updateIcons()`.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message