cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sterlingann <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #273: Cb-12098 (iOS) update supportedinterfaceorien...
Date Fri, 04 Nov 2016 17:45:46 GMT
GitHub user sterlingann opened a pull request:

    https://github.com/apache/cordova-ios/pull/273

    Cb-12098 (iOS) update supportedinterfaceorientations return type

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Updates return type to UIInterfaceOrientationMask in iOS 9+
    
    ### What testing has been done on this change?
    created test project, automated NPM test
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sterlingann/cordova-ios CB-12098

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #273
    
----
commit 63e14a1ed4b387552a9386176b3d02b23adeaf1e
Author: Sterling <sterlingann@gmail.com>
Date:   2016-11-01T18:40:12Z

    CB-12098 - Update supportedInterfaceOrientations return type

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message