cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kelvinhokk <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #24: CB-10228:(iOS) AppendUserA...
Date Tue, 29 Nov 2016 09:21:31 GMT
GitHub user kelvinhokk opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24

    CB-10228:(iOS) AppendUserAgent not working with WKWebView

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS: Currently the wkWebview users the default user agent, ignoring Cordova's OverrideUserAgent
and AppendUserAgent in config.xml
    
    ### What does this PR do?
    This attempts to set the customUserAgent property of the wkWebview to what is already
computed in the CDVViewController
    
    ### What testing has been done on this change?
    Npm tests have been run.  User agents verified changed on Cordova iOS 4.3.0 and Cordova
6.4.0.
    
    ### Checklist
    - [ X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kelvinhokk/cordova-plugin-wkwebview-engine master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 8014757681d79fc83d96bff00ca1b262f0b4b25b
Author: kelvinho <kelvinho@igloohome.co>
Date:   2016-11-29T09:20:02Z

    CB-10228:(iOS) AppendUserAgent not working with WKWebView

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message