cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...
Date Fri, 25 Nov 2016 10:33:45 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/212

    CB-9287 Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Add JPG support, added missing splashscreen scales for projects
    cordova.js - refine splashscreen extension based on config.xml
    Added a warning when non-MRT splash screens have mixed extensions
    Added a warning for size limit exceeding (applies to win10 project only)
    Added a warning for images with unsupported format
    Tests
    
    [Jira issue CB-9287](https://issues.apache.org/jira/browse/CB-9287)
    
    ### What testing has been done on this change?
    Manual and auto tests
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-windows CB-9287

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #212
    
----
commit d4640969dc2b9b7b5322629a899c040fb9496a26
Author: daserge <v-seshak@microsoft.com>
Date:   2016-11-25T10:30:46Z

    CB-9287 Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
    
    Add JPG support
    cordova.js - refine splashscreen extension based on config.xml
    Added a warning when non-MRT splash screens have mixed extensions
    Added a warning for size limit exceeding (applies to win10 project only)
    Added a warning for images with unsupported format

commit bd0096b71a3d6d65169d7d4582e50a05dc48ecb0
Author: daserge <v-seshak@microsoft.com>
Date:   2016-11-25T10:31:03Z

    CB-9287 Not enough Icons and Splashscreens for Windows 8.1 and Windows Phone 8.1
    
    Tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message