cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #208: CB-12071 Fix for CB-11825 breaks usage of...
Date Tue, 01 Nov 2016 08:32:25 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/208

    CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova …

    …Windows
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Adds a test for missing InProcessServer extension case to prevent further breakages
    
    ### What testing has been done on this change?
    Run npm test, checked that None package action breaks the test.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-windows CB-12071

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #208
    
----
commit 369f69a0618658209f29027abb1c114761ce5b83
Author: daserge <v-seshak@microsoft.com>
Date:   2016-11-01T08:27:49Z

    CB-12071 Fix for CB-11825 breaks usage of InProcessServer in Cordova Windows
    
    Adds a test for missing InProcessServer extension case to prevent further breakages

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message