cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tmoxon <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #198: CB-12145: (android) Allow thi...
Date Mon, 14 Nov 2016 20:28:21 GMT
GitHub user tmoxon opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/198

     CB-12145: (android) Allow third party cookies if parameter set

    Affects: Android 5+
    
    Creates a new parameter for Android browser setup: acceptThirdPartyCookies. If set to
'yes' then, for Android 5 and above, the cookie manager policy to allow third party cookies
will be set.
    
    Note that this is not entirely original in concept - a [PR was already raised](https://github.com/apache/cordova-plugin-inappbrowser/pull/165)
for this however I've expanded on this to make it optional which seems pragmatic given the
role of the in app browser.
    
    I have built and tested this against android 4.x and 6.x phones in both modes and confirmed
behaviours.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tmoxon/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #198
    
----
commit e3b971673537f111782a22477f8e6fa2fb6ea54d
Author: Tim Moxon <tim.moxon@brightstarr.com>
Date:   2016-11-14T20:02:47Z

    Added third party cookie policy by acceptThirdPartyCookies parameter.

commit 81f35dc8bcbe9ffd94f05468953a4ff6b28bc37e
Author: Tim Moxon <tim.moxon@brightstarr.com>
Date:   2016-11-14T20:11:43Z

    Fixed spacing

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message