cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ghenry22 <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #197: CB-12132: (android & ios) imp...
Date Fri, 11 Nov 2016 07:41:44 GMT
GitHub user ghenry22 opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/197

    CB-12132: (android & ios) implement hidenotclose feature

    
    ### Platforms affected
    android & ios
    
    ### What does this PR do?
    This adds a new option hidenotclose which can be passed to the
    inappbrowser.
    
    When set to yes the done button on iOS or the X button android will
    hide the web view instead of closing it.
    
    This allows the user to show/hide the web view multiple times without
    having to reload the content and you can clean up when you know they
    are done by calling close once.
    
    ### What testing has been done on this change?
    manually tested on both android and ios with both enabled and disabled settings.
    when disabled (as by default) existing behaviour is maintained
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [O] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ghenry22/cordova-plugin-inappbrowser hide_not_close

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #197
    
----
commit ec563a7af77e9f74cc73be8fd1a606946d4b4809
Author: ghenry22 <ghenry22@gmail.com>
Date:   2016-11-11T07:39:35Z

    CB-12132: (android & ios) implement hidenotclose feature
    
    This adds a new option hidenotclose which can be passed to the
    inappbrowser.
    
    When set to yes the done button on iOS or the X button android will
    hide the web view instead of closing it.
    
    This allows the user to show/hide the web view multiple times without
    having to reload the content and you can clean up when you know they
    are done by calling close once.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message