cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vladimir Kotikov (Akvelon)" <>
Subject Re: Windows platform refactoring
Date Fri, 25 Nov 2016 07:46:15 GMT
Thanks, Jesse! 

Best regards, Vladimir

On 11/25/16, 10:03, "Jesse" <> wrote:

    Sorry for the late reply, missed this email in the spam folder.
    These changes look great, thanks!
    On Thu, Nov 17, 2016 at 6:30 AM, Vladimir Kotikov (Akvelon) <> wrote:
    > Hey all
    > Just FUI, we're done some refactoring that aims to move some
    > windows-specific logic (in particular, applying <config-file> changes to
    > appxmanifests files) out of cordova-common into cordova-windows. I hope
    > this would simplify maintenance of both cordova-common and cordova-windows
    > in future
    > Just in case if anyone is interested, here is the PR that these windows
    > bits from cordova-common:
    > cordova-lib/pull/505/files, and this PR adds them to cordova-windows:
Note that changes in
    > windows are backward compatible, I.e. it will continue to work with
    > previous versions of cordova-common, so we don't need to merge them at once
    > and do a release ASAP
    > I was going to merge this by tomorrow EOD, but if anyone wants to take a
    > look - I would appreciate any feedback
    > Thanks
    > -
    > Best regards, Vladimir

View raw message