cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kerri Shotts <kerrisho...@gmail.com>
Subject Re: [DISCUSS] cordova-ios 4.3.1 patch release
Date Tue, 22 Nov 2016 22:18:42 GMT
Thanks!

Pushed to 4.3.x.

~ Kerri

> On Nov 22, 2016, at 13:11, Shazron <shazron@gmail.com> wrote:
> 
> Thanks Kerri, please do push it to 4.3.x
> I'll take mobile-spec out for spin with your changes.
> 
> On Tue, Nov 22, 2016 at 10:59 AM, Kerri Shotts <kerrishotts@gmail.com>
> wrote:
> 
>> All,
>> 
>> I think I’ve got everything fixed for the storyboard feature. I’ve tested
>> it on my side along with the new automated tests using Travis & Appveyor.
>> 
>> IIRC, the reason the storyboard feature was disabled for 4.3.0 was a build
>> failure in mobilespec. I’m able to build my local mobilespec just fine, but
>> it would be fantastic if someone else could test and make sure that
>> mobilespec builds correctly for them as well. If it doesn’t, I’d love to
>> see the error message that is generated (if any).
>> 
>> @shazron: I cherry-picked the commits for CB-12084, CB-12130, CB-12155 to
>> my own 4.3.x branch (https://github.com/kerrishotts/cordova-ios/
>> commits/4.3.x). If the commits look OK (I used -x), I can push to Apache
>> so you don’t have to cherry-pick them yourself, unless you really, really
>> want to. ;-)
>> 
>> ~ Kerri
>> 
>>> On Nov 18, 2016, at 18:29, Shazron <shazron@gmail.com> wrote:
>>> 
>>> I'll get that in Connor. Thanks for the PR!
>>> 
>>> On Fri, Nov 18, 2016 at 5:35 AM, Connor Pearson <cjp822@gmail.com>
>> wrote:
>>> 
>>>> Could we also include CB-11243? It can block submissions to iTunes
>> Connect
>>>> if you aren't building a universal app.
>>>> 
>>>> On Wed, Nov 16, 2016 at 4:52 PM, Kerri Shotts <kerrishotts@gmail.com>
>>>> wrote:
>>>> 
>>>>> Cool. I’m working on a couple things related to launch storyboards:
>>>>> 
>>>>> - CB-12155: automated tests for launch storyboards, so we can feel
>>>>> confident things are working as they should — in progress; probably
33%
>>>>> done (so if I’m lucky, done by EOW).
>>>>> - CB-12084: clean breaking Xcode project — this also let me know that
I
>>>>> need to tweak the Launch Images build setting depending on certain
>>>>> situations. I’ve already got this built — PR coming soon which should
>>>> kick
>>>>> off CI.
>>>>> 
>>>>> I’ve got CB-9762 open as the top-level issue for everything I’m working
>>>> on.
>>>>> 
>>>>> ~ Kerri
>>>>> 
>>>>>> On Nov 16, 2016, at 15:34, Shazron <shazron@gmail.com> wrote:
>>>>>> 
>>>>>> Kerri, I will cherry-pick the fixes for the two issues you worked
on
>>>> into
>>>>>> the 4.3.x branch when you are done.
>>>>>> 
>>>>>> On Wed, Nov 16, 2016 at 1:31 PM, Shazron <shazron@gmail.com>
wrote:
>>>>>> 
>>>>>>> Any other issues that need to go in this release? The main focus
has
>>>>> been
>>>>>>> to patch any new features that were released in 4.3.0. If not,
they
>>>>> would
>>>>>>> go in 4.4.0 (next version) or 5.0.0 (next year).
>>>>>>> 
>>>>>>> See: https://issues.apache.org/jira/issues/?jql=
>>>>>>> fixVersion%20%3D%20%22cordova-ios%404.3.1%22%20AND%
>>>> 20project%20%3D%20CB
>>>>>>> (Kerri is working on that last issue, before I prepare the release)
>>>>>>> 
>>>>>>> 
>>>>> 
>>>>> 
>>>> 
>> 
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message