cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...
Date Tue, 29 Nov 2016 19:40:50 GMT
Github user shazron commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23#discussion_r90091089
  
    --- Diff: src/ios/CDVWKWebViewEngine.m ---
    @@ -123,6 +123,32 @@ - (void)pluginInitialize
                    name:UIApplicationWillEnterForegroundNotification object:nil];
     
         NSLog(@"Using WKWebView");
    +
    +    [self addURLObserver];
    +}
    +
    +- (void)onReset {
    +    [self addURLObserver];
    +}
    +
    +static void * KVOContext = &KVOContext;
    +
    +- (void)addURLObserver {
    +    if(![[NSProcessInfo processInfo] isOperatingSystemAtLeastVersion:(NSOperatingSystemVersion){.majorVersion
= 9, .minorVersion = 0, .patchVersion = 0 }]){
    --- End diff --
    
    To make it simpler, you can use `IsAtLeastiOSVersion(@"9.0")`  (from CDVAvailability.h)
    I'm not sure how this whole patch would work for iOS 8, because of this note: https://github.com/apache/cordova-plugin-wkwebview-engine#notes
    
    Is this for a "using a local webserver" context?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message