cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...
Date Tue, 29 Nov 2016 12:10:27 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: cordova-js-src/splashscreen.js ---
    @@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue, cfg) {
    +// Refine splashscreen file extension to match what is in config.xml
    +function refineSplashScreenExtension(cfg) {
    --- End diff --
    > Then we'll need to manipulate the Image.src anyway as it is in different format.
    Why? Isn't the logic in 'prepare' supposed to update splash screen file name to actual
value? The benefit IMO is that you'll have one place where you're trying to infer splashscreen
real filename based on `splashscreen` preferences

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message