cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...
Date Tue, 29 Nov 2016 12:10:27 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: template/cordova/lib/prepare.js ---
    @@ -297,48 +305,80 @@ function applyNavigationWhitelist(config, manifest) {
    -function mapImageResources(images, imagesDir) {
    -    var pathMap = {};
    +// Platform default images
    +var platformImages = [
    --- End diff --
    nit: could you please make it uppercase, so i'd be easy to understand in code that we're
using some constant value

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message