cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...
Date Mon, 28 Nov 2016 14:37:34 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/212#discussion_r89792140
  
    --- Diff: cordova-js-src/splashscreen.js ---
    @@ -58,8 +58,45 @@ function readBoolFromCfg(preferenceName, defaultValue, cfg) {
         }
     }
     
    +// Refine splashscreen file extension to match what is in config.xml
    +function refineSplashScreenExtension(cfg) {
    --- End diff --
    
    We could go that way and add another method in confighelper like `readManifest` but:
    1. I'm not sure how it will affect performance (confighelper is based on async xhr),
    2. Then we'll need to manipulate the Image.src anyway as it is in different format.
    
    The benefit of this approach is more confidence that we are using the correct (base)name
- but it is not an issue as it is hardcoded now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message