cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...
Date Mon, 28 Nov 2016 14:22:23 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/212#discussion_r89789288
  
    --- Diff: template/cordova/lib/prepare.js ---
    @@ -353,6 +391,13 @@ function mapImageResources(images, imagesDir) {
                     events.emit('warn', 'No images found for target: ' + img.target);
                 } else {
                     candidates.forEach(function(mrtImage) {
    +                    if (img.target === SPLASH_SCREEN_DESKTOP_TARGET_NAME &&
    +                        mrtSplashScreenToTargetProject(mrtImage) === TARGET_PROJECT_10
&&
    +                        exceedsSizeLimit(mrtImage.path)) {
    --- End diff --
    
    This does not result in a build failure and the issue could only be seen in Visual Studio
manifest designer so I believe the warning is useful here.
    Do you mean we should fail the build rather than showing this warning?
    It currently just skips oversized images.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message