cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #212: CB-9287 Not enough Icons and Splashscreen...
Date Mon, 28 Nov 2016 09:10:55 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/212#discussion_r89726640
  
    --- Diff: spec/unit/Prepare.Win10.spec.js ---
    @@ -541,4 +541,165 @@ describe('copyIcons method', function () {
                 expect(FileUpdater.updatePaths).toHaveBeenCalledWith(expectedPathMap, { rootDir:
PROJECT }, logFileOp);
             });
         });
    +
    +    it('should ignore splashScreens for Windows 10 project with size >200K and emit
a warning', function () {
    +        var size300K = 300 * 1024;
    +        var warnSpy = jasmine.createSpy('warn');
    +        events.on('warn', warnSpy);
    +
    +        var splashScreensFiles = [
    --- End diff --
    
    Nit: this could be calculated from `splashScreens`: `splashScreens.map(splash => path.basename(splash.src)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message