cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #207: Move windows-specific logic from cordova-...
Date Mon, 14 Nov 2016 08:10:26 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/207#discussion_r87750373
  
    --- Diff: template/cordova/lib/ConfigChanges.js ---
    @@ -159,4 +160,16 @@ function generateUapCapabilities(capabilities) {
     
     }
     
    +/**
    + * This is an override of generate_plugin_config_munge method from cordova-common's PluginInfo
class.
    + * @param  {[Object]} pluginInfo instance of 'PluginInfo'
    + * @param  {[Object]} vars plugin's variables
    + * @param  {[Object]} edit_config_changes
    + * @return {[Object]} plugin's munge
    + */
    +PlatformMunger.prototype.generate_plugin_config_munge = function (pluginInfo, vars, edit_config_changes)
{
    +     var self = this;
    --- End diff --
    
    This doesn't seem to be requried - calling a prototype is not a closure so you can safely
use `this`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message