cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ghenry22 <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser issue #197: CB-12132: (android & ios) implement ...
Date Sat, 12 Nov 2016 14:54:41 GMT
Github user ghenry22 commented on the issue:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/197
  
    The new methods follow what is implemented for close, where there are 2 close methods,
one designed for the user to call and one for use with a selector that the done button will
hit.
    
    In order to have minimal changes to the existing code and keep the logic consistent I
have implemented the same for the hide method.  You can just reuse the existing hide method
as it expects a parameter which cannot be passed when it is used as a selector.  Hence the
2 close methods as well.
    
    The browserHide method is implemented in line with the browserExit method again for consistent
behaviour.  While there is some code duplication it seems that it is necessary because of
the different use cases, or called as selector vs called by user from javascript.
    
    I have implemented for iOS and android, I could possibly do windows as well but I don't
have the devices to test other platforms.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message