cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-plugin-device-orientation pull request #31: CB-9179 (ios) Fixed true...
Date Thu, 03 Nov 2016 09:56:37 GMT
Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-device-orientation/pull/31#discussion_r86310927
  
    --- Diff: tests/tests.js ---
    @@ -157,6 +157,19 @@ exports.defineManualTests = function (contentEl, createActionButton)
{
             document.getElementById('compass_status').innerHTML = status;
         }
     
    +    // Success callback for both watchHeading and getCurrentHeading
    +    function success(a) {
    +        var magneticheading = document.getElementById('magneticHeading');
    --- End diff --
    
    Thanks for catching it. I wonder why it appeared to be working when I was testing it...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message