Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: dpogue <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
Message-ID: <git-pr-340-cordova-android@git.apache.org>
Subject: [GitHub] cordova-android pull request #340: CB-8722 - Move app icons from drawable to...
Content-Type: text/plain
Date: Thu,  6 Oct 2016 19:58:08 +0000 (UTC)
archived-at: Thu, 06 Oct 2016 19:58:11 -0000

GitHub user dpogue opened a pull request:

    https://github.com/apache/cordova-android/pull/340

    CB-8722 - Move app icons from drawable to mipmap

    https://issues.apache.org/jira/browse/CB-8722
    
    Reasoning behind the change: https://androidbycode.wordpress.com/2015/02/14/goodbye-launcher-drawables-hello-mipmaps/
    
    /cc @infil00p 
    This probably counts as a breaking change, so we might want to get this into 6.0

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpogue/cordova-android mipmap

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #340
    
----
commit 97855018e9aeb955f3dd7e31c91fb6b8f67e0c29
Author: Darryl Pogue <darryl@ayogo.com>
Date:   2016-10-06T19:55:26Z

    CB-8722 - Move icons from drawable to mipmap

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org