Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: PaulTaykalo <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-117-cordova-plugin-splashscreen@git.apache.org>
In-Reply-To: <git-pr-117-cordova-plugin-splashscreen@git.apache.org>
Subject: [GitHub] cordova-plugin-splashscreen pull request #117: CB-12062: (ios) Fix crash whe...
Content-Type: text/plain
Message-Id: <20161026073439.3A199DFB92@git1-us-west.apache.org>
Date: Wed, 26 Oct 2016 07:34:39 +0000 (UTC)
archived-at: Wed, 26 Oct 2016 07:34:41 -0000

GitHub user PaulTaykalo reopened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/117

    CB-12062: (ios) Fix crash when listening for KVO changes for deallocated object

    ### Platforms affected
    ios
    
    ### What does this PR do?
    Fix crash when listening for KVO changes for deallocated object
    
    ### What testing has been done on this change?
    Tests aded
    
    
    ### Checklist
    - ✅ [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - ✅ Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - ✅ Added automated test coverage as appropriate for this change.
    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PaulTaykalo/cordova-plugin-splashscreen fix/kvo-crashing-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
    
----
commit 58044c7b16ab84652b0545e19b1cdc8636d83c51
Author: Paul Taykalo <tt.kilew@gmail.com>
Date:   2016-10-25T14:49:05Z

    Fix crash when listening for KVO changes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org