Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: giuseppelt <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-196-cordova-windows@git.apache.org>
In-Reply-To: <git-pr-196-cordova-windows@git.apache.org>
Subject: [GitHub] cordova-windows issue #196: Fix setSplashBgColor exception when no splashscr...
Content-Type: text/plain
Message-Id: <20161018135401.29980E0209@git1-us-west.apache.org>
Date: Tue, 18 Oct 2016 13:54:01 +0000 (UTC)
archived-at: Tue, 18 Oct 2016 13:54:03 -0000

Github user giuseppelt commented on the issue:

    https://github.com/apache/cordova-windows/pull/196
  
    Schema is incorrect or old.
    
    According to https://msdn.microsoft.com/en-us/library/windows/apps/ff769511(v=vs.105).aspx splashscreen isn't required nor it's provided in the default template.
    
    > Windows Phone 8 apps load quickly, so a Windows Phone 8 app usually doesn’t need a splash screen. New Windows Phone 8 projects don’t include a default splash screen image file. However, if you want to use a splash screen in your Windows Phone 8 app, add an existing JPG image file to the root folder of your Windows Phone 8 project, and name the file SplashScreenImage.jpg.
    
    Anyway the patch here, doesn't delete the element, but just avoid null-reference when the node isn't present, like in the default template.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org