Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: shazron <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-238-cordova-plugin-camera@git.apache.org>
In-Reply-To: <git-pr-238-cordova-plugin-camera@git.apache.org>
Subject: [GitHub] cordova-plugin-camera issue #238: targetWidth and targetHeight bigger than o...
Content-Type: text/plain
Message-Id: <20161010173811.8481BE04BE@git1-us-west.apache.org>
Date: Mon, 10 Oct 2016 17:38:11 +0000 (UTC)
archived-at: Mon, 10 Oct 2016 17:38:13 -0000

Github user shazron commented on the issue:

    https://github.com/apache/cordova-plugin-camera/pull/238
  
    This makes sense, but is a backwards incompatible change since the behaviour changes, and some may be using that behaviour.
    
    Either:
    1. Increment the major version number, document the breaking change. Users using the old behaviour won't be surprised with this change because we follow semver.
    OR
    2. Keep the current behaviour, but add a new option "upscale" (suggested) that defaults to `true`. This would be a minor version change since its a new feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org