Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: vladimir-kotikov <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-17-cordova-paramedic@git.apache.org>
In-Reply-To: <git-pr-17-cordova-paramedic@git.apache.org>
Subject: [GitHub] cordova-paramedic pull request #17: CB-11926 Pass the file transfer server a...
Content-Type: text/plain
Message-Id: <20161004070357.4787AE00C7@git1-us-west.apache.org>
Date: Tue,  4 Oct 2016 07:03:57 +0000 (UTC)
archived-at: Tue, 04 Oct 2016 07:03:59 -0000

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-paramedic/pull/17#discussion_r81695543
  
    --- Diff: lib/PluginsManager.js ---
    @@ -41,16 +43,31 @@ PluginsManager.prototype.installTestsForExistingPlugins = function () {
         installedPlugins.forEach(function(plugin) {
             // there is test plugin available
             if (fs.existsSync(path.join(plugin.dir, 'tests', 'plugin.xml'))) {
    -            me.installSinglePlugin(path.join(plugin.dir, 'tests'));
    +            var additionalArgs = '';
    +            if (plugin.id.indexOf('cordova-plugin-file-transfer') >= 0) {
    +                var fileServerUrl = Server.prototype.getConnectionAddress.bind({
    +                    externalServerUrl: me.config.getExternalServerUrl()
    +                }, me.config.getPlatformId())() + ':5000';
    +                additionalArgs += ' --variable FILETRANSFER_SERVER_ADDRESS=' + fileServerUrl;
    +            }
    +            me.installSinglePlugin(path.join(plugin.dir, 'tests') + additionalArgs);
             }
         });
         // this will list installed plugins and their versions
         this.showPluginsVersions();
     };
     
     PluginsManager.prototype.installSinglePlugin = function (plugin) {
    -    if (fs.existsSync(path.resolve(this.storedCWD, plugin))) {
    -        plugin = path.resolve(this.storedCWD, plugin);
    +    var pluginPath = plugin;
    +    var args = '';
    +    // separate plugin name from args
    +    var argsIndex = plugin.indexOf(' --');
    --- End diff --
    
    So you're building a string in `installTestsForExistingPlugins` and then splitting it back to `(plugin, arguments)` tuple? I don't think this is an efficient way to pass additional arguments to the function. Can we just add an optional argument to be able to specify any flags to `cordova plugin add`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org