cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jedofus <>
Subject [GitHub] cordova-plugin-dialogs pull request #88: /!/Alert on startapp
Date Thu, 06 Oct 2016 15:34:47 GMT
GitHub user jedofus opened a pull request:

    /!/Alert on startapp

    Hello , i have problem since i updated platform ios on cordova .
    i use this code on my onDeviceready() 
    `		if (navigator.notification) { // Override default HTML alert with native dialog
    			window.alert = function (message) {
    			      message,    // message
    			      null,       // callback
    			      getText('application-title'), // title
    			      getText('ok')        // buttonName
    no problem before update. But after update ios platform and this plugin , i always have
an alert with message "1" . I do not know how to remove this alert . Can anyone solve my problem?

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #88
commit 5ecb3506e0de87d0465713857af132e68c543f00
Author: Kevin Boosten <>
Date:   2016-08-16T07:34:00Z

    Make sure the alert buttonLabel is a string

commit 02a424255b601a64fc2c5d5c4f5ff4b31a0cd5c5
Author: Jesse MacFadyen <>
Date:   2016-09-09T20:38:33Z

    Added test for [windows] CB-11281 when called without defaultText

commit 542e7f7c9f9b5a6d9af48f71549c7d988f91145a
Author: Steve Gill <>
Date:   2016-09-09T23:08:04Z

    CB-11832 Incremented plugin version.

commit 9a19139eefb0981a178f531cd502bfdd08233c83
Author: Steve Gill <>
Date:   2016-09-09T23:27:11Z

    Merge branch 'master' of

commit 5ebefa82d5220b4525602b3c38e9198095f80d8c
Author: Jesse MacFadyen <>
Date:   2016-09-09T23:05:38Z

    Add enter key handling and map to default button.

commit 68ceff4d0ef5c5de9144d09d7a05712c439951c1
Author: Jesse MacFadyen <>
Date:   2016-09-09T23:27:49Z

    Fix dumb linting error

commit d34092cd37c386b02d836c9cac5c14b38415e111
Author: Jesse MacFadyen <>
Date:   2016-09-09T23:34:23Z

    Close #86

commit 137fa7c84cc909577584a9f55ca1f37e9db031b7
Author: Jesse MacFadyen <>
Date:   2016-09-10T00:26:06Z

    Merge branch 'master' of

commit 2b732482a5cf9dc4814dcb22cf5fc6a94ee652ba
Author: Jesse MacFadyen <>
Date:   2016-09-10T00:37:07Z

    Replace empty buttonLabel with 'OK'

commit baee8130920a74514fd809808b1939b3fbfa94af
Author: Jesse MacFadyen <>
Date:   2016-09-10T00:45:36Z

    Close #43

commit 6606fcb6389be8973eeed1d30166fb7e34505496
Author: Shazron Abdullah <>
Date:   2016-09-28T08:33:44Z

    CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…"
     This closes #87


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message