cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lquinn <>
Subject [GitHub] cordova-plugin-globalization pull request #52: CB-12029 blackberry10: Remove...
Date Mon, 17 Oct 2016 17:34:29 GMT
GitHub user lquinn opened a pull request:

    CB-12029 blackberry10: Remove logging code that causes crashes on BB10

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    Removes logging code that caused crashes.
    ### What testing has been done on this change?
    Compiled. The patch is a straightforward removal of the logging code.
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    The blackberry10 globalization plugin used the slog2 API improperly,
    leading to crashes in Cordova apps that use this plugin. Remove the
    logging as the safest, simplest fix.

You can merge this pull request into a Git repository by running:

    $ git pull CB-12029cordova-plugin-globalization

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #52


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message