cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From audreyso <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #499: Cb 11960
Date Mon, 10 Oct 2016 23:18:13 GMT
GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-lib/pull/499

    Cb 11960

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Will work when adding all platforms.
    
    ### What does this PR do?
    When adding or removing a platform (with --save), the specified platform will be added
or removed from the package.json file.
    
    ### What testing has been done on this change?
    Added and removed platforms to see if package.json updates properly.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-lib CB-11960

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #499
    
----
commit 16576d90145be4de6dd628227f3e65b9a4f4545c
Author: audreyso <auso@adobe.com>
Date:   2016-10-04T00:50:51Z

    CB-8995 renamed start to plugman install/uninstall start to make CordovaLib tests more
descriptive

commit 7fc9f3c2f74353033e1c64178ec86b71d16b1bc9
Author: audreyso <auso@adobe.com>
Date:   2016-10-07T21:19:06Z

    CB-11960 specified platform is now added to both a config.xml and package.json file when
saved

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message