cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sterlingann <...@git.apache.org>
Subject [GitHub] cordova-android pull request #344: Cb 5968
Date Sat, 29 Oct 2016 00:44:13 GMT
GitHub user sterlingann opened a pull request:

    https://github.com/apache/cordova-android/pull/344

    Cb 5968

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    
    modified template so that xxhdpi and xxxhdpi directories are now automatically generated
for drawables and mipmaps.   Aspect ratios are changed slightly because I did a simple scale
from hdpi.  
     
    ### What testing has been done on this change?
    created a test project to make sure that the new folders and images were autogenerated

    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sterlingann/cordova-android CB-5968

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #344
    
----
commit e31634b0fbdf72cd30b399aa84d843057b1380e5
Author: Sterling <sterlingann@gmail.com>
Date:   2016-10-29T00:03:45Z

    created directories and corresponding images for xxhdpi and xxxhdpi, both drawables and
mipmaps

commit 700b425774ad4d037335d2978953047eb56debd9
Author: Sterling <sterlingann@gmail.com>
Date:   2016-10-29T00:20:56Z

    replaced with unstretched images

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message