cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adzellman <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #265: CB-11952 - Introduce buildFlag option
Date Thu, 06 Oct 2016 21:41:09 GMT
GitHub user adzellman opened a pull request:

    https://github.com/apache/cordova-ios/pull/265

    CB-11952 - Introduce buildFlag option

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    
    - adds buildFlag option for passing args to xcodebuild
    - There can be multiple --buildFlag declarations
    - Warns if buildFlag would override a built-in setting
    
    ### What testing has been done on this change?
    
    - Added unit tests for build.js
    - I have tried this out with by passing various legal and illegal flags using the --buildFlag
option. I used the xcodebuild man page to develop test cases.
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adzellman/aemm-ios CB-11952

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #265
    
----
commit e393738fe1f26824555bd090d1e08a725ed75f88
Author: Andrew Zellman <zellman@adobe.com>
Date:   2016-10-05T22:14:59Z

    CB-11952 - Introduce buildFlag option
    - adds buildFlag option for passing args to xcodebuild
    - There can be multiple --buildFlag declarations
    - Warns if buildFlag would override a built-in setting

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message