cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adzellman <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #263: CB-11952 - Introduce buildFlag option
Date Wed, 05 Oct 2016 22:20:44 GMT
GitHub user adzellman opened a pull request:

    https://github.com/apache/cordova-ios/pull/263

    CB-11952 - Introduce buildFlag option

    ### Platforms affected
    iOS
    
    ### What does this PR do?
     - Add buildFlag option for passing args to xcodebuild
     - There can be multiple --buildFlag declarations
     - Warns if buildFlag would override a built-in setting
    
    ### What testing has been done on this change?
    I have tried this out with by passing various legal and illegal flags using the --buildFlag
option. I used the [xcodebuild man page](https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man1/xcodebuild.1.html)
to develop test cases.
    
    ### Checklist
    - [] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adzellman/aemm-ios CB-11952

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/263.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #263
    
----
commit dcbcaa466a3240eb277a5fcbd0691f18c21d3326
Author: Andrew Zellman <zellman@adobe.com>
Date:   2016-10-05T22:14:59Z

    CB-11952 - Introduce buildFlag option
     - Allows user to pass arguments to xcodebuild

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message