cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fareshan <>
Subject [GitHub] cordova-plugin-camera pull request #238: targetWidth and targetHeight bigger...
Date Sat, 08 Oct 2016 21:35:26 GMT
GitHub user fareshan opened a pull request:

    targetWidth and targetHeight bigger than original picture

    ### Platforms affected
    Android, iOS (i can not test for other platforms)
    ### What does this PR do?
    When setting targetWidth and targetHeight to a bigger size than original picture, the
result picture should be sized like the original picture
    ### What testing has been done on this change?
    I tested on version 2.3.0 on iPhone and android emulators.
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x]  CB-11987: (android, ios) Fix bug with targetWidth and targetHeight bigger than
original picture
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #238
commit 569b069a03cf99d599cdee8e685935a706046cf4
Author: Fares Hantous <>
Date:   2016-10-08T20:49:21Z

    prevent the creation of picture bigger than original for ios

commit 67755254fca55bd1a6ea1a38ebb835cf972617db
Author: Fares Hantous <>
Date:   2016-10-08T20:49:38Z

    prevent the creation of picture bigger than original for android


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message