cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cjpearson <...@git.apache.org>
Subject [GitHub] cordova-plugin-wkwebview-engine pull request #23: CB-11997: Add crash recove...
Date Tue, 11 Oct 2016 18:09:01 GMT
GitHub user cjpearson opened a pull request:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23

    CB-11997: Add crash recovery for iOS 8

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS
    
    ### What does this PR do?
    Reloads the WebView when it crashes. This behavior already exists on iOS >= 9, but
has not been added for iOS 8.
    
    ### What testing has been done on this change?
    I've tried consuming a bunch of memory in javascript to cause a crash. The app reloads
successfully.
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjpearson/cordova-plugin-wkwebview-engine master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-wkwebview-engine/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit d9d30f2cf91f307b44ecc5efe1763ae7d0b3bdb3
Author: Connor Pearson <cjp822@gmail.com>
Date:   2016-10-11T18:04:37Z

    CB-11997: Add crash recovery for iOS 8

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message