cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-windows pull request #206: CB-11825 Revert Windows dll file won't be...
Date Mon, 31 Oct 2016 13:23:45 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/206

    CB-11825 Revert Windows dll file won't be copied as resource while ad…

    …ding custom plugin to a UWP project
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    The real issue was in a plugin wrong configuration - resource-file.target (Content.Link)
should use backslashes (reverted from commit 1417b932c836c0fe21cca902e5098fa12e98fe82)
    
    ### What testing has been done on this change?
    Run platform autotests, created and run helloworld project
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-windows CB-11825

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #206
    
----
commit 91776b778e371df2440d135f86a0e5cf90f973c2
Author: daserge <v-seshak@microsoft.com>
Date:   2016-10-31T12:31:43Z

    CB-11825 Revert Windows dll file won't be copied as resource while adding custom plugin
to a UWP project
    
    The real issue was in a plugin wrong configuration - resource-file.target (Content.Link)
should use backslashes (reverted from commit 1417b932c836c0fe21cca902e5098fa12e98fe82)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message