cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From PhilippeMorier <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #196: CB-NONE: (android) Set correc...
Date Fri, 28 Oct 2016 14:40:47 GMT
GitHub user PhilippeMorier opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/196

    CB-NONE: (android) Set correct content description for close button

    ### Platforms affected
    Android
    
    ### What does this PR do?
    Fix the wrongly set content description of the forward & close button. This is relevant
if a screen reader is activated.
    
    ### What testing has been done on this change?
    npm test
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PhilippeMorier/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #196
    
----
commit b7abcceaf5fd32105ba2dcae3e0a9f4c505c6d36
Author: Philippe Morier <thorgal.hayne@outlook.com>
Date:   2016-10-28T14:21:08Z

    fix(close button): Set correct content description

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message