cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sterlingann <>
Subject [GitHub] cordova-plugin-inappbrowser pull request #195: Cb 6229
Date Thu, 27 Oct 2016 22:21:55 GMT
GitHub user sterlingann opened a pull request:

    Cb 6229

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    Gives the developer the ability to either show or hide the edit text containing the url
as well as the toolbar buttons.
    ### What testing has been done on this change?
    Tested all combinations of 'yes' and 'no' values for both location and toolbar.
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-6229

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #195
commit 16cd8d1f8457982dce646e145a2781d565dafc62
Author: Sterling <>
Date:   2016-10-26T23:33:02Z

    updated to give developers option of hiding the url in the toolbar

commit 383a0f8634103b6c835339bd00e1fb11f38874ef
Author: Sterling <>
Date:   2016-10-27T22:04:23Z

    added functionality of showing/hiding the toolbar buttons


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message