cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #193: CB-10973 inAppBrowser for Win...
Date Wed, 19 Oct 2016 10:00:00 GMT
GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/193

    CB-10973 inAppBrowser for Windows Platform: wrong height of webview w…

    …ith location=yes
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Windows
    
    ### What does this PR do?
    Redoing as there was still a little gap
    
    ### What testing has been done on this change?
    Tested on Windows Phone 8.1 Lumia 640, 525,
    Windows 10 Mobile 525, 1520,
    Windows 10 desktop
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-inappbrowser CB-10973

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #193
    
----
commit 19182dace270697a5c41416c654159bb0c542b35
Author: daserge <v-seshak@microsoft.com>
Date:   2016-10-19T09:52:11Z

    CB-10973 inAppBrowser for Windows Platform: wrong height of webview with location=yes
    
    Redoing as there was still a little gap

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message