cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Webpal <>
Subject [GitHub] cordova-plugin-file-transfer pull request #161: Allowing chunkedMode to be f...
Date Thu, 13 Oct 2016 11:54:13 GMT
GitHub user Webpal opened a pull request:

    Allowing chunkedMode to be false on Android / https

    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    ### Platforms affected
    ### What does this PR do?
    File uploads over https were automatically turned to Transfer-encoding: chunked due to
old Android issues. Since adding this header to transfers often breaks functionality (for
example you can't add an additional header to an Amazon S3 request that was signed without
it) - isn't it better to follow the users instruction to use chunked mode or not instead of
overwriting it? 
    ### What testing has been done on this change?
    Only deployed on one Android device, can not verify that it doesn't cause OOM issues -
but this option is available as a setting for the user to controll in js.
    ### Checklist
    - [ ] [Reported an issue]( in the JIRA
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
commit e836377a0ff6e2fda810f65a8220413b2095a3ec
Author: Webpal <>
Date:   2016-10-13T11:44:11Z



If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message